linux-kernel - Re: [PATCH] Perf: Use /usr/bin/pager if available for perf pager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120529114506.7c8d6157@pyramind.ukuu.org.uk>
Date:	Tue, 29 May 2012 11:45:06 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Avik Sil <avik.sil@...aro.org>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
	acme@...stprotocols.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Perf: Use /usr/bin/pager if available for perf pager

On Tue, 29 May 2012 16:05:25 +0530
Avik Sil <avik.sil@...aro.org> wrote:

> Some Distributions may lack "less" package being included by default, e.g., Linaro nano rootfs. In those cases use the portable "pager" command instead of "less".
> 
> Signed-off-by: Avik Sil <avik.sil@...aro.org>
> ---
>  tools/perf/util/pager.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/util/pager.c b/tools/perf/util/pager.c
> index 1915de2..3322b84 100644
> --- a/tools/perf/util/pager.c
> +++ b/tools/perf/util/pager.c
> @@ -57,6 +57,10 @@ void setup_pager(void)
>  	}
>  	if (!pager)
>  		pager = getenv("PAGER");
> +	if (!pager) {
> +		if (!access("/usr/bin/pager", X_OK))
> +			pager = "/usr/bin/pager";
> +	}

What is "portable" about /usr/bin/pager ? and what is wrong with just
doing

export PAGER=/usr/bin/pager

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/