linux-kernel - Re: [PATCH v3 07/16] block: Rename bio_split() -> bio_pair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 May 2012 22:15:15 -0400
From:	Kent Overstreet <koverstreet@...gle.com>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org,
	dm-devel@...hat.com, linux-fsdevel@...r.kernel.org, tj@...nel.org,
	axboe@...nel.dk, agk@...hat.com, neilb@...e.de,
	drbd-dev@...ts.linbit.com, vgoyal@...hat.com, mpatocka@...hat.com,
	sage@...dream.net, yehuda@...newdream.net
Subject: Re: [PATCH v3 07/16] block: Rename bio_split() -> bio_pair_split()

On Mon, May 28, 2012 at 01:15:39PM +0300, Boaz Harrosh wrote:
> On 05/25/2012 11:25 PM, Kent Overstreet wrote:
> 
> > This is prep work for introducing a more general bio_split()
> > 
> > Change-Id: Ib9c4ff691af889d26bc9ec9fb42a2f3068f34ad9
> > 
> 
> 
> Since these patches will go through Jens tree this kind of
> comment can *never* be true/correct. And it is plenty unwanted
> for sure.

That's from a gerrit hook, which I always forget to delete so I just
disabled the hook on my work machine. Apologies.

> Here:
> bio_do means an operation on bio. But here we are actually operating
> on a bio_pair. So rename it it to bio_pair_do.

I don't follow what you mean by bio_do... but I think I get what you're
after, comment wise.

> 
> We will later introduce a real bio_split() function that receives
> a bio and splits it.
> 
> Or something like that.
> Thanks
> Boaz
> 
> > Signed-off-by: Kent Overstreet <koverstreet@...gle.com>
> 
> <snip>
> 
> > @@ -201,7 +201,7 @@ struct bio_pair {
> >  	atomic_t			cnt;
> >  	int				error;
> >  };
> > -extern struct bio_pair *bio_split(struct bio *bi, int first_sectors);
> > +extern struct bio_pair *bio_pair_split(struct bio *bi, int first_sectors);
> >  extern void bio_pair_release(struct bio_pair *dbio);
> >  
> >  extern struct bio_set *bioset_create(unsigned int, unsigned int);
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/