linux-kernel - Re: [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 May 2012 12:52:13 -0500
From:	Jon Hunter <jon-hunter@...com>
To:	<jgq516@...il.com>
CC:	<linux@....linux.org.uk>, <b-cousson@...com>,
	<rob.herring@...xeda.com>, <grant.likely@...retlab.ca>,
	<rnayak@...com>, <tony@...mide.com>, <wim@...ana.be>,
	<devicetree-discuss@...ts.ozlabs.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4


On 05/25/2012 05:42 AM, jgq516@...il.com wrote:
> From: Xiao Jiang <jgq516@...il.com>
> 
> Add wdt node to support dt.
> 
> Signed-off-by: Xiao Jiang <jgq516@...il.com>
> ---
>  arch/arm/boot/dts/omap3.dtsi |    5 +++++
>  arch/arm/boot/dts/omap4.dtsi |    5 +++++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index 99474fa..039df5c 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -215,5 +215,10 @@
>  			compatible = "ti,omap3-hsmmc";
>  			ti,hwmods = "mmc3";
>  		};
> +
> +		wdt: wdt@...14000{

Minor comment, may be call this wdt2 as this is watchdog timer 2. Also
ass a space between the address and the "{".

> +			compatible = "ti,omap3-wdt";
> +			ti,hwmods = "wd_timer2";
> +		};
>  	};
>  };
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 359c497..d01403d 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -272,5 +272,10 @@
>  			ti,hwmods = "mmc5";
>  			ti,needs-special-reset;
>  		};
> +
> +		wdt: wdt@...14000{

Same as above.

> +			compatible = "ti,omap4-wdt";
> +			ti,hwmods = "wd_timer2";
> +		};
>  	};
>  };

Also we should add some documentation to describe the binding. Here it
is very simple, but nonetheless we should have something as we have for
gpio [1].

Cheers
Jon

[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/devicetree/bindings/gpio/gpio-omap.txt;h=bff51a2fee1eae7d387b40ea913e04782554bf68;hb=HEAD
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/