linux-kernel - Re: [PATCH] x86: kernel/early_printk.c simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1338324091.2722.9.camel@lorien2>
Date:	Tue, 29 May 2012 14:41:31 -0600
From:	Shuah Khan <shuahkhan@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	shuahkhan@...il.com, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, x86@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: kernel/early_printk.c simple_strtoul cleanup

On Sun, 2012-05-27 at 13:51 -0700, Joe Perches wrote:
> On Sun, 2012-05-27 at 10:48 -0600, Shuah Khan wrote:
> > Change early_serial_init() to call kstrtoul() instead of calling obsoleted
> > simple_strtoul().
> []
> > diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
> []
> > @@ -119,22 +119,27 @@ static __init void early_serial_init(char *s)
> >  	unsigned char c;
> >  	unsigned divisor;
> >  	unsigned baud = DEFAULT_BAUD;
> > -	char *e;
> > +	unsigned long val;
> > +	ssize_t ret;
> >  
> >  	if (*s == ',')
> >  		++s;
> >  
> >  	if (*s) {
> > -		unsigned port;
> > +		unsigned port = 0;
> >  		if (!strncmp(s, "0x", 2)) {
> > -			early_serial_base = simple_strtoul(s, &e, 16);
> > +			ret = kstrtoul(s, 16, &val);
> > +			if (!ret)
> > +				early_serial_base = val;
> 
> I believe none of the kstrto<foo> calls set
> the value in the pointer unless successful so
> you don't need a temporary and can simply use:
> 
> 		ret = kstrtoint(s, 16, &early_serial_base)
> 		if (ret)
> 
> etc...

Will re-work the patch and resend it.

Thanks,
-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/