[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1338276092.15008.68.camel@cumari.coelho.fi>
Date: Tue, 29 May 2012 10:21:32 +0300
From: Luciano Coelho <coelho@...com>
To: Eyal Shapira <eyal@...ery.com>,
"John W. Linville" <linville@...driver.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-next@...r.kernel.org,
Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] wlcore: fix undefined symbols when CONFIG_PM is not
defined
On Tue, 2012-05-29 at 00:15 -0700, Eyal Shapira wrote:
> commit 5063c201d7b799d6cb36d3edfc2c2c3db3b400e5
> "wl12xx: add RX filters ACX commands" breaks the build
> when CONFIG_PM isn't defined:
>
> ERROR: "wl1271_rx_filter_get_fields_size"
> [drivers/net/wireless/ti/wlcore/wlcore.ko] undefined!
> ERROR: "wl1271_rx_filter_flatten_fields"
> [drivers/net/wireless/ti/wlcore/wlcore.ko] undefined!
>
> code in drivers/net/wireless/ti/wlcore/acx.c is using these
> functions unconditionally while they are #ifdefed CONFIG_PM.
> Fix it by ifdefing all relevant RX filters code with CONFIG_PM.
>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Eyal Shapira <eyal@...ery.com>
> ---
Acked-by: Luciano Coelho <coelho@...com>
Thanks, Eyal!
John, can you push this up so it gets applied for 3.5?
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists