linux-kernel - Re: [PATCH] crypto: serpent - add x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120530103025.19252e1urui8sfb4@www.81.fi>
Date:	Wed, 30 May 2012 10:30:25 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Johannes Goetzfried 
	<Johannes.Goetzfried@...ormatik.stud.uni-erlangen.de>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	Tilo Müller 
	<tilo.mueller@...ormatik.uni-erlangen.de>
Subject: Re: [PATCH] crypto: serpent - add x86_64/avx assembler
 implementation

Quoting Andi Kleen <andi@...stfloor.org>:

>
> The driver needs CPUID annotations now (since 3.3), so that it can be
> autoloaded.  Something like:
>

Is it really good idea to autoload crypto modules? Currently loading  
different cipher implementations is handled via module-aliases and  
cipher priorities. With autoloading by CPUID, crypto-modules would be  
loaded and be mostly unused. For example, serpent-sse2 would be  
autoloaded on all x86-64 kernels (well, on those that have it compiled  
as module => probably most of distros).

IMHO these should be loaded only when needed, as is done with generic  
i586/x86-64 assembler cipher implementations.

-Jussi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/