lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 30 May 2012 16:47:08 +0900
From:	Tejun Heo <>
To:	Kent Overstreet <>
Subject: Re: [Bcache v13 11/16] bcache: Core btree code

A couple more comments from this round of reading.

On Wed, May 09, 2012 at 11:10:48PM -0400, Kent Overstreet wrote:
> +#define btree_prio		USHRT_MAX
> +#define initial_prio		32768

Why are these in lower case?

> +#define PTR_BUCKET(c, k, n)						\
> +	(PTR_CACHE(c, k, n)->buckets + PTR_BUCKET_NR(c, k, n))

PTR_BUCKET(c, k, n)

Awesome.  I don't know what type it takes or what each single
character argument stands for.

> +static inline bool cached_dev_get(struct cached_dev *d)
> +{
> +	if (!atomic_inc_not_zero(&d->count))
> +		return false;
> +
> +	smp_mb__after_atomic_inc();

What is this mb() paired with?  Whenever using a mb, please specify
what the mb is paired with.

> +	return true;
> +}


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists