linux-kernel - Re: include/linux/dynamic_debug.h:111:2: error: implicit declaration of function ‘strstr’

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 May 2012 18:43:23 -0700
From:	shawn <shawnlandden@...il.com>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	Jason Baron <jbaron@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: include/linux/dynamic_debug.h:111:2: error: implicit
 declaration of function ‘strstr’

jim,
On Tue, 2012-05-29 at 19:11 -0600, Jim Cromie wrote: 
> On Tue, May 29, 2012 at 5:31 PM, shawn <shawnlandden@...il.com> wrote:
> >  SHIPPED arch/arm/boot/compressed/lib1funcs.S
> > In file included from include/linux/kernel.h:23:0,
> >                 from
> > arch/arm/boot/compressed/../../../../lib/xz/xz_private.h:15,
> >                 from
> > arch/arm/boot/compressed/../../../../lib/decompress_unxz.c:145,
> >                 from arch/arm/boot/compressed/decompress.c:50:
> > include/linux/dynamic_debug.h: In function
> > ‘ddebug_dyndbg_module_param_cb’:
> > include/linux/dynamic_debug.h:111:2: error: implicit declaration of
> > function ‘strstr’ [-Werror=implicit-function-declaration]
> >
> > git blame shows b48420c1d3019ce8d84fb8e58f4ca86b8e3655b8 as introducing
> > this call
> 
> that symbol should have been provided by line 100
> 
>      98 #else
>      99
>     100 #include <linux/string.h>
>     101 #include <linux/errno.h>
> ...
>     108 static inline int ddebug_dyndbg_module_param_cb(char *param, char *val,
>     109                                                 const char *modname)
>     110 {
>     111         if (strstr(param, "dyndbg")) {

> which has:
> 
>      74 #ifndef __HAVE_ARCH_STRSTR
>      75 extern char * strstr(const char *, const char *);
>      76 #endif
> does your arch have __HAVE_ARCH_STRSTR ?
> if so, is strstr exported under different conditions ??
a git grep __HAVE_ARCH_STRSTR did not show and such defines in the arm
tree 
> 
> Can you send me
> arch/arm/boot/compressed/decompress.i  ?
I didn't have that file after the failure, but 

make arch/arm/boot/compressed/decompress.i

summoned it, also including string.o from that folder (which was present
after the failure)

I am compiling on amd64, using 
export ARCH=arm
and 
CONFIG_CROSS_COMPILE="arm-linux-gnueabi-"


I have had issues with the cross compiler not always being called since
the 3.5 merge window opened up, (ld reporting corrupted binary files and
gcc saying it doesn't understand arm-specific flags) and have not yet
compiled a post-v3.4 successful kernel. This could be a symptom of that.
(esp as the host arch, x86 DOES have __HAVE_ARCH_STRSTR)

-- 
-Shawn Landden

Download attachment "string.o" of type "application/x-object" (1984 bytes)

View attachment "decompress.i" of type "text/plain" (111645 bytes)