| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4FC6358F.2010405@zytor.com> Date: Wed, 30 May 2012 07:58:23 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: Borislav Petkov <bp@...en8.de>, Andre Przywara <andre.przywara@....com>, mingo@...e.hu, tglx@...utronix.de, konrad.wilk@...cle.com, jeremy@...p.org, linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com, stable@...r.kernel.org.#.3.4+ Subject: Re: [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems On 05/30/2012 07:55 AM, Borislav Petkov wrote: > On Wed, May 30, 2012 at 07:42:27AM -0700, H. Peter Anvin wrote: >> On 05/30/2012 06:10 AM, Andre Przywara wrote: >>> Because we are behind a family check before tweaking the topology >>> bit, we can use the standard rd/wrmsr variants for the CPUID feature >>> register. >> >> That is not what the *msr*_amd*() functions do. >> >> NAK. This is a totally bogus patch. > > The *msr*_amd*() variants were used instead of the normal *msrl_safe > variants although the AMD variants weren't needed there at all. > > This has no issue on baremetal but breaks xen and this is how we caught > this. > > So the patch corrects the original patch so that xen is happy too. > If so, then fix the description to match reality and we can take the patch. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists