linux-kernel - Re: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (RFC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 May 2012 17:29:48 +0200
From:	Borislav Petkov <bp@...64.org>
To:	"Liu, Jinsong" <jinsong.liu@...el.com>
Cc:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"Luck, Tony" <tony.luck@...el.com>,
	"'xen-devel@...ts.xensource.com'" <xen-devel@...ts.xensource.com>
Subject: Re: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (RFC)

On Wed, May 30, 2012 at 03:20:03PM +0000, Liu, Jinsong wrote:
> >> IMO currently there are 2 options:
> >> 1). use the original approach (implicitly redirect /dev/mcelog to
> >> xen_mce_chrdev_device) --> what point of this approach do you think
> >> unreasonable? It just remove a 'static' from native mce code! 2).
> >> use another /dev/xen-mcelog interface, with another misc minor '226'
> > 
> > The 2) is no good.
> > 
> > 3) What about moving the corresponding other users (so
> > threshold_init_device), to be at late_initcall and the mce to be at
> > late_initcall_sync 
> 
> I can try, but only if Boris would not jump out.
> and it can only be tested by Boris at AMD platform :(

Sure, I'll test it.

However, it should be a separate patch, not merged with this one.

So, I don't see anything speaking against making threshold_init_device a
late_initcall leading to the following order:

device_initcall <- xen
device_initcall_sync <- arch/x86
fs_initcall <- threshold_init_device

and the "xen" line not happening on baremetal; which shouldn't change
anything noticeably in the init-order mce-wise.

Also, add a comment at the end of mce_amd.c saying why
threshold_init_device should be last.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/