linux-kernel - Re: [PATCH] sched: Don't try allocating memory from offline nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1205292019560.14373@chino.kir.corp.google.com>
Date:	Tue, 29 May 2012 20:21:13 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	"Luck, Tony" <tony.luck@...el.com>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] sched: Don't try allocating memory from offline nodes

On Tue, 29 May 2012, Luck, Tony wrote:

> Index: linux-2.6/kernel/sched/core.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched/core.c
> +++ linux-2.6/kernel/sched/core.c
> @@ -6449,7 +6449,7 @@ static void sched_init_numa(void)
>  			return;
>  
>  		for (j = 0; j < nr_node_ids; j++) {
> -			struct cpumask *mask = kzalloc_node(cpumask_size(), GFP_KERNEL, j);
> +			struct cpumask *mask = kzalloc(cpumask_size(), GFP_KERNEL);
>  			if (!mask)
>  				return;
>  

It's definitely better if we can allocate on the node, though, so perhaps 
do the same thing that I did in 
http://marc.info/?l=linux-kernel&m=133778739503111 by doing
kzalloc_node(..., node_online(j) ? j : NUMA_NO_NODE)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/