linux-kernel - Re: [GIT PULL] Block driver bits for 3.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFysiKSfawC3my5jP11ChNdkvuz2TjJstFhM+6CSmnbpzg@mail.gmail.com>
Date:	Wed, 30 May 2012 13:58:37 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Jens Axboe <jaxboe@...ionio.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>, Alan Cox <alan@...ux.intel.com>
Subject: Re: [GIT PULL] Block driver bits for 3.5

Eric, can you verify that reverting that one commit on top of current
-git fixes things for you?

I'm a bit surprised that it would be that simple commit that actually
just *removes* a mutex use that causes it, so the bisect result looks
a bit fishy. Maybe it's a race that doesn't always cause the lockup at
boot, in which case it might have bisected to the wrong thing..

But if reverting that commit from top-of-tree fixes it, that's pretty
unambiguous.

                    Linus

On Wed, May 30, 2012 at 1:35 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> commit d3ca8b64b97ef4dc54d7bb0b88bbc01a1fca8cb9
> Author: Alan Cox <alan@...ux.intel.com>
> Date:   Tue May 29 13:45:01 2012 +0100
>
>    pty: Fix lock inversion
>
>    The ptmx_open path takes the tty and devpts locks in the wrong order
>    because tty_init_dev locks and returns a locked tty.  As far as I can
>    tell this is actually safe anyway because the tty being returned is new
>    so nobody can get a reference to lock it at this point.
>
>    However we don't even need the devpts lock at this point, it's only held
>    as a byproduct of the way the locks were pushe down.
>
>    Signed-off-by: Alan Cox <alan@...ux.intel.com>
>    Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/