linux-kernel - Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120531072541.GC5377@arwen.pp.htv.fi>
Date:	Thu, 31 May 2012 10:25:42 +0300
From:	Felipe Balbi <balbi@...com>
To:	Joe Perches <joe@...ches.com>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for &

On Wed, May 30, 2012 at 01:25:57PM -0700, Joe Perches wrote:
> Using | with a constant is always true.
> Likely this should have be &.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

this looks good to me. Do you want me to carry it on my tree ?

If you want to carry it out as a fix:

Acked-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/usb/gadget/pch_udc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
> index 1cfcc9e..f4fb71c 100644
> --- a/drivers/usb/gadget/pch_udc.c
> +++ b/drivers/usb/gadget/pch_udc.c
> @@ -2208,7 +2208,7 @@ static void pch_udc_complete_receiver(struct pch_udc_ep *ep)
>  			return;
>  		}
>  		if ((td->status & PCH_UDC_BUFF_STS) == PCH_UDC_BS_DMA_DONE)
> -			if (td->status | PCH_UDC_DMA_LAST) {
> +			if (td->status & PCH_UDC_DMA_LAST) {
>  				count = td->status & PCH_UDC_RXTX_BYTES;
>  				break;
>  			}
> -- 
> 1.7.8.111.gad25c.dirty
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)