linux-kernel - Re: [PATCH -V7 10/14] hugetlbfs: Add new HugeTLB cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120531094355.GB12809@tiehlicka.suse.cz>
Date:	Thu, 31 May 2012 11:43:56 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	Konrad Rzeszutek Wilk <konrad@...nok.org>, linux-mm@...ck.org,
	kamezawa.hiroyu@...fujitsu.com, dhillf@...il.com,
	rientjes@...gle.com, akpm@...ux-foundation.org, hannes@...xchg.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org
Subject: Re: [PATCH -V7 10/14] hugetlbfs: Add new HugeTLB cgroup

On Thu 31-05-12 11:13:16, Aneesh Kumar K.V wrote:
> On Wed, May 30, 2012 at 09:19:54PM -0400, Konrad Rzeszutek Wilk wrote:
[...]
> > > +static struct cgroup_subsys_state *hugetlb_cgroup_create(struct cgroup *cgroup)
> > > +{
> > > +	int idx;
> > > +	struct cgroup *parent_cgroup;
> > > +	struct hugetlb_cgroup *h_cgroup, *parent_h_cgroup;
> > > +
> > > +	h_cgroup = kzalloc(sizeof(*h_cgroup), GFP_KERNEL);
> > > +	if (!h_cgroup)
> > > +		return ERR_PTR(-ENOMEM);
> > > +
> > 
> > No need to check cgroup for NULL?
> 
> Other cgroups (memcg) doesn't do that. Can we really get NULL cgroup tere ?

No we cannot. See cfa449461e67b60df986170eecb089831fa9e49a

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/