linux-kernel - [PATCH] block: avoid infinite loop in get_task_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1338460706.2760.1330.camel@edumazet-glaptop>
Date:	Thu, 31 May 2012 12:38:26 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>, Alan Cox <alan@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] block: avoid infinite loop in get_task_io_context()

From: Eric Dumazet <edumazet@...gle.com>

On Wed, 2012-05-30 at 22:35 +0200, Eric Dumazet wrote:
> On Wed, 2012-05-30 at 21:08 +0200, Eric Dumazet wrote:
> > On Wed, 2012-05-30 at 20:55 +0200, Jens Axboe wrote:
> > > On 05/30/2012 08:33 PM, Eric Dumazet wrote:
> > > > On Wed, 2012-05-30 at 14:54 +0200, Jens Axboe wrote:
> > > >> Hi Linus,
> > > >>
> > > >> On top of the for-3.5/core pull request, here are the driver related
> > > >> changes for 3.5. It contains:
> > > > 
> > > > Hi Jens
> > > > 
> > > > Not sure if this is related, but latest Linus tree cannot boot anymore
> > > > here...
> > > > 
> > > > BUG: soft lockup - CPU#3 stuck for 22s ! [mountall.1603]
> > > 
> > > Hrmpf, can you attach your .config?
> > > 
> > 
> > I can do a bisection pretty fast I think
> 
> Not sure if bisection was good, but result is :

Bisection gave nothing, because its an old bug ?

Following patch cures it.

[PATCH] block: avoid infinite loop in get_task_io_context()

Calling get_task_io_context() on a exiting task which isn't %current can
loop forever. This triggers at boot time on my dev machine.

BUG: soft lockup - CPU#3 stuck for 22s ! [mountall.1603]

Fix this by making create_task_io_context() returns -EBUSY in this case
to break the loop.

Signed-off-by: Eric Dumazet <edumazet@...gle.com>
Cc: Tejun Heo <tj@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Alan Cox <alan@...ux.intel.com>
---
 block/blk-ioc.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/block/blk-ioc.c b/block/blk-ioc.c
index 1e2d53b..893b800 100644
--- a/block/blk-ioc.c
+++ b/block/blk-ioc.c
@@ -235,6 +235,7 @@ void ioc_clear_queue(struct request_queue *q)
 int create_task_io_context(struct task_struct *task, gfp_t gfp_flags, int node)
 {
 	struct io_context *ioc;
+	int ret;
 
 	ioc = kmem_cache_alloc_node(iocontext_cachep, gfp_flags | __GFP_ZERO,
 				    node);
@@ -262,9 +263,12 @@ int create_task_io_context(struct task_struct *task, gfp_t gfp_flags, int node)
 		task->io_context = ioc;
 	else
 		kmem_cache_free(iocontext_cachep, ioc);
+
+	ret = task->io_context ? 0 : -EBUSY;
+
 	task_unlock(task);
 
-	return 0;
+	return ret;
 }
 
 /**


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/