linux-kernel - Re: [PATCH 1/3] uprobes: install_breakpoint() should fail if is_swbp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120531125411.GA24279@linux.vnet.ibm.com>
Date:	Thu, 31 May 2012 18:24:11 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Oleg Nesterov <oleg@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <anton@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] uprobes: install_breakpoint() should fail if
 is_swbp_insn() == T

* Peter Zijlstra <peterz@...radead.org> [2012-05-31 14:15:18]:

> On Wed, 2012-05-30 at 19:49 +0200, Peter Zijlstra wrote:
> > 
> > Oh, indeed. I overlooked copy_insn() is taking the page from the
> > page-cache instead of the page-tables and will thus get the original.
> > 
> 
> Related to this, what happens when we try to install a probe on a page
> that's already been COWed by a ptrace user?
> 
> Say gdb did a code modification at or near the intended probe site.
> 

If the page is already COWED because of an existing code modification
near the intended probe site, we are replacing it with another page
keeping the previous modification as is.

ptrace and uprobes tracing the same instruction wont work cleanly for
now.

-- 
thanks and regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/