linux-kernel - Re: Lots of i915/drm spew on 3.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+gsUGTP5S9Az5oHMxYgyJbDPv9R7gRoC614RW0OLk7_TBeDZQ@mail.gmail.com>
Date:	Thu, 31 May 2012 10:22:28 -0300
From:	Paulo Zanoni <przanoni@...il.com>
To:	Chris Wilson <chris@...is-wilson.co.uk>
Cc:	Dave Jones <davej@...hat.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	dri-devel@...ts.freedesktop.org, Dave Airlie <airlied@...hat.com>,
	Paulo Zanoni <paulo.r.zanoni@...el.com>,
	Rob Clark <rob.clark@...aro.org>
Subject: Re: Lots of i915/drm spew on 3.4

2012/5/31 Chris Wilson <chris@...is-wilson.co.uk>:
> Before that commit we had no idea that we had run out of property slots.
> I think the WARN is genuine, but maybe we should just bump the count set
> it to WARN_ONCE and hope the conversion to lists arrives sooner rather
> than latter.
> -Chris
>

Chris is right: this is not a regression. Before that patch, no one
checked if property creation really worked. I chose not to use
WARN_ONCE because we need to increase the variable once for each time
you see the message. Assuming this message appears on your log less
than 8 times, does this patch fix your problem?

diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 73e4560..bac55c2 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -54,7 +54,7 @@ struct drm_mode_object {
        struct drm_object_properties *properties;
 };

-#define DRM_OBJECT_MAX_PROPERTY 16
+#define DRM_OBJECT_MAX_PROPERTY 24
 struct drm_object_properties {
        int count;
        uint32_t ids[DRM_OBJECT_MAX_PROPERTY];




-- 
Paulo Zanoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/