linux-kernel - Re: [PATCHv5 5/5] kvm: host side for eoi optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120531145219.GA20290@redhat.com>
Date:	Thu, 31 May 2012 17:52:20 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Gleb Natapov <gleb@...hat.com>
Cc:	x86@...nel.org, kvm@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Avi Kivity <avi@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCHv5 5/5] kvm: host side for eoi optimization

On Thu, May 31, 2012 at 01:15:13PM +0300, Gleb Natapov wrote:
> > > > +	    /* Cache not set: safe but we don't bother. */
> > > > +	    unlikely(apic->isr_cache == -1) ||
> > > > +	    /* Need EOI to update ioapic. */
> > > > +	    unlikely(kvm_ioapic_handles_vector(vcpu->kvm, apic->isr_cache)))
> > > > +		return;
> > > > +
> > > > +	pv_eoi_set_pending(apic->vcpu);
> > > > +}
> > > > +
> > > apic_sync_pv_eoi_to_guest() is not paired with
> > > apic_sync_pv_eoi_from_guest() if event injection is canceled.
> > > You can enter guest with stale pv_eoi bit.
> > 
> > Never. The pv_eoi bit is cleared on each exit.
> There will be no exit since there will be no entry. Search for
> "goto out" after kvm_lapic_sync_to_vapic().

I think you've found a bug, thanks a bunch.
I have fixed it but the x86 guys asked me not to
post more patches until merge window closes :(
So I'll sit on a fix for several days.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/