linux-kernel - Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.1206010204150.8697@eggly.anvils>
Date:	Fri, 1 Jun 2012 02:08:07 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
cc:	Dave Jones <davej@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Cong Wang <amwang@...hat.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: WARNING: at mm/page-writeback.c:1990
 __set_page_dirty_nobuffers+0x13a/0x170()

On Fri, 1 Jun 2012, KOSAKI Motohiro wrote:
> >   	mlock_migrate_page(newpage, page);
> > --- 3.4.0+/mm/page-writeback.c	2012-05-29 08:09:58.304806782 -0700
> > +++ linux/mm/page-writeback.c	2012-06-01 00:23:43.984116973 -0700
> > @@ -1987,7 +1987,10 @@ int __set_page_dirty_nobuffers(struct pa
> >   		mapping2 = page_mapping(page);
> >   		if (mapping2) { /* Race with truncate? */
> >   			BUG_ON(mapping2 != mapping);
> > -			WARN_ON_ONCE(!PagePrivate(page)&&
> > !PageUptodate(page));
> > +			if (WARN_ON(!PagePrivate(page)&&
> > !PageUptodate(page)))
> > +				print_symbol(KERN_WARNING
> > +				    "mapping->a_ops->writepage: %s\n",
> > +				    (unsigned
> > long)mapping->a_ops->writepage);
> 
> type mismatch?

I don't think so: I just copied from print_bad_pte().
Probably you're reading "printk" where it's "print_symbol"?

> I guess you want %pf or %pF.

I expect there is new-fangled %pMagic that can do it too, yes.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/