linux-kernel - Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Jun 2012 12:50:27 +0300
From:	Felipe Balbi <balbi@...com>
To:	Joe Perches <joe@...ches.com>
Cc:	balbi@...com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for &

On Thu, May 31, 2012 at 12:44:43PM -0700, Joe Perches wrote:
> On Thu, 2012-05-31 at 10:25 +0300, Felipe Balbi wrote:
> > On Wed, May 30, 2012 at 01:25:57PM -0700, Joe Perches wrote:
> > > Using | with a constant is always true.
> > > Likely this should have be &.
> > > Signed-off-by: Joe Perches <joe@...ches.com>
> > this looks good to me. Do you want me to carry it on my tree ?
> > If you want to carry it out as a fix:
> > Acked-by: Felipe Balbi <balbi@...com>
> 
> I presume that question is for Greg.

Then I'll take it... driver/usb/gadget/ goes through me.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)