linux-kernel - Re: [PATCH 05/11] mtip32xx: Set block queue boundary variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49d35jyy5y.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 01 Jun 2012 09:11:37 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Asai Thambi S P <asamymuthupa@...ron.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Sam Bradshaw <sbradshaw@...ron.com>
Subject: Re: [PATCH 05/11] mtip32xx: Set block queue boundary variables

Jens Axboe <axboe@...nel.dk> writes:

>> Jens, I actually think changing nr_requests makes sense;  the only
>> question in my mind is where to do it.  (There's no point in artificially
>> limiting the device by default.)  IIRC, your general rule was to set this
>> value to 2x the device's queue depth.  So, given that this driver
>> doesn't use the blk-tag interfaces, what do you think would be the
>> cleanest way to bump nr_requests in this (and the more general) case?
>
> But it doesn't matter for this case, the driver isn't consuming request
> structures, hence the value set doesn't make any difference. So the only
> limiter of queue depth is the driver itself.

Good point.  Nevermind.  ;-)

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/