linux-kernel - Re: [PATCH 2/2] lapb-nl: Added driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120601155446.51751e61@pyramind.ukuu.org.uk>
Date:	Fri, 1 Jun 2012 15:54:46 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sergey Lapin <slapin@...fans.org>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, linux-x25@...r.kernel.org
Subject: Re: [PATCH 2/2] lapb-nl: Added driver

On the socket family side I was thinking not of a "lapb-nl" socket layer
but a simple pure LAPB socket - that just uses interface name type
addressing and only supported SOCK_RAW for raw data frames over LAPB
encodings.


> > Again the sl->tty locking needs sorting (I think this may well be true of
> > slip and the others too)
> 
> Could you please explain a bit more on this?

In modern kernels the tty object is refcounted and not locked by any big
global locks.

So in your open do

	tty = tty_kref_get(tty);

and in the close
	tty_kref_put(tty);

and you are guaranteed the tty won't vanish under you between those
points.

> > Why flush ?
> Problems occured a long time ago, will remove and check.

That should be handled by the core code now.

> The whole thing is data packat transfer. Application is also notified when
> packet is delivered. That's it, no fancy stuff. There is also UDP code, but it is
> weird mess, and I think if it is to live or be removed. What do you think?

Weird mess removal is always good stuff.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/