linux-kernel - Re: [PATCH 05/20] hexagon: Do not call do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Jun 2012 14:01:35 -0500
From:	Richard Kuo <rkuo@...eaurora.org>
To:	David Brown <davidb@...eaurora.org>
Cc:	Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, linux-hexagon@...r.kernel.org
Subject: Re: [PATCH 05/20] hexagon: Do not call do_signal() with irqs
 disabled

On Fri, Jun 01, 2012 at 11:42:12AM -0700, David Brown wrote:
> On Fri, Jun 01, 2012 at 12:54:59PM -0500, Richard Kuo wrote:
> > On Sat, May 26, 2012 at 12:04:21AM +0200, Richard Weinberger wrote:
> > > get_signal_to_deliver() calls try_to_freeze() which might sleep.
> > > 
> > > Cc: Richard Kuo <rkuo@...eaurora.org>
> > > Cc: linux-hexagon@...r.kernel.org
> > > Signed-off-by: Richard Weinberger <richard@....at>
> > > ---
> > >  arch/hexagon/kernel/signal.c |    3 +++
> > >  1 files changed, 3 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> > > index 434866e..8403bfd 100644
> > > --- a/arch/hexagon/kernel/signal.c
> > > +++ b/arch/hexagon/kernel/signal.c
> > > @@ -22,6 +22,7 @@
> > >  #include <linux/syscalls.h>
> > >  #include <linux/freezer.h>
> > >  #include <linux/tracehook.h>
> > > +#include <linux/irqflags.h>
> > >  #include <asm/registers.h>
> > >  #include <asm/thread_info.h>
> > >  #include <asm/unistd.h>
> > > @@ -267,6 +268,8 @@ no_restart:
> > >  
> > >  void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
> > >  {
> > > +	local_irq_enable();
> > > +
> > >  	if (thread_info_flags & _TIF_SIGPENDING)
> > >  		do_signal(regs);
> > >  
> > > -- 
> > > 1.7.7.3
> > 
> > Signed-off-by: Richard Kuo <rkuo@...eaurora.org>
> 
> Did you mean Acked-by?  Replying to an email with a Signed-off-by
> doesn't mean anything.  If you're pulling the patch into your own
> tree, add the SoB at that point.  If you want to reply that you've
> accepted a patch, just say so in English.
> 
> David

Doh, sorry, I really meant Acked-by.  Thanks for catching that.


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/