linux-kernel - RE: [PATCH] Tools: hv: verify origin of netlink connector message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Jun 2012 19:26:44 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Olaf Hering <olaf@...fle.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Tools: hv: verify origin of netlink connector message



> -----Original Message-----
> From: Olaf Hering [mailto:olaf@...fle.de]
> Sent: Thursday, May 31, 2012 10:40 AM
> To: KY Srinivasan; Greg Kroah-Hartman
> Cc: linux-kernel@...r.kernel.org
> Subject: [PATCH] Tools: hv: verify origin of netlink connector message
> 
> The SuSE security team suggested to use recvfrom instead of recv to be
> certain that the connector message is originated from kernel.

Thanks Olaf.

> 
> Signed-off-by: Olaf Hering <olaf@...fle.de>

Signed-off-by:  K. Y. Srinivasan <kys@...rosoft.com>

> 
> ---
>  tools/hv/hv_kvp_daemon.c |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> Index: linux-3.4/tools/hv/hv_kvp_daemon.c
> ==============================================================
> =====
> --- linux-3.4.orig/tools/hv/hv_kvp_daemon.c
> +++ linux-3.4/tools/hv/hv_kvp_daemon.c
> @@ -701,14 +701,18 @@ int main(void)
>  	pfd.fd = fd;
> 
>  	while (1) {
> +		struct sockaddr *addr_p = (struct sockaddr *) &addr;
> +		socklen_t addr_l = sizeof(addr);
>  		pfd.events = POLLIN;
>  		pfd.revents = 0;
>  		poll(&pfd, 1, -1);
> 
> -		len = recv(fd, kvp_recv_buffer, sizeof(kvp_recv_buffer), 0);
> +		len = recvfrom(fd, kvp_recv_buffer, sizeof(kvp_recv_buffer), 0,
> +				addr_p, &addr_l);
> 
> -		if (len < 0) {
> -			syslog(LOG_ERR, "recv failed; error:%d", len);
> +		if (len < 0 || addr.nl_pid) {
> +			syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s",
> +					addr.nl_pid, errno, strerror(errno));
>  			close(fd);
>  			return -1;
>  		}
> 
>