linux-kernel - Re: [PATCH 1/4] PCI: make pci_ltr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FC93BF4.8040207@redhat.com>
Date:	Fri, 01 Jun 2012 18:02:28 -0400
From:	Don Dutile <ddutile@...hat.com>
To:	Myron Stowe <myron.stowe@...hat.com>
CC:	bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, xudong.hao@...ux.intel.com,
	yu.zhao@...el.com
Subject: Re: [PATCH 1/4] PCI: make pci_ltr_supported static.

On 06/01/2012 05:16 PM, Myron Stowe wrote:
> The PCI Express Latency Tolerance Reporting (LTR) feature's
> pci_ltr_supported() routine is currently only used within
> drivers/pci/pci.c so make it static.
>
> Signed-off-by: Myron Stowe<myron.stowe@...hat.com>
> ---
>
Acked-by: Donald Dutile <ddutile@...hat.com>

>   drivers/pci/pci.c   |    4 ++--
>   include/linux/pci.h |    1 -
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 447e834..64471b1 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -39,6 +39,7 @@ EXPORT_SYMBOL(pci_pci_problems);
>
>   unsigned int pci_pm_d3_delay;
>
> +static bool pci_ltr_supported(struct pci_dev *dev);
>   static void pci_pme_list_scan(struct work_struct *work);
>
>   static LIST_HEAD(pci_pme_list);
> @@ -2169,7 +2170,7 @@ EXPORT_SYMBOL(pci_disable_obff);
>    * RETURNS:
>    * True if @dev supports latency tolerance reporting, false otherwise.
>    */
> -bool pci_ltr_supported(struct pci_dev *dev)
> +static bool pci_ltr_supported(struct pci_dev *dev)
>   {
>   	int pos;
>   	u32 cap;
> @@ -2185,7 +2186,6 @@ bool pci_ltr_supported(struct pci_dev *dev)
>
>   	return cap&  PCI_EXP_DEVCAP2_LTR;
>   }
> -EXPORT_SYMBOL(pci_ltr_supported);
>
>   /**
>    * pci_enable_ltr - enable latency tolerance reporting
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index d8c379d..b2bec26 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -875,7 +875,6 @@ enum pci_obff_signal_type {
>   int pci_enable_obff(struct pci_dev *dev, enum pci_obff_signal_type);
>   void pci_disable_obff(struct pci_dev *dev);
>
> -bool pci_ltr_supported(struct pci_dev *dev);
>   int pci_enable_ltr(struct pci_dev *dev);
>   void pci_disable_ltr(struct pci_dev *dev);
>   int pci_set_ltr(struct pci_dev *dev, int snoop_lat_ns, int nosnoop_lat_ns);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/