| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4FC85780.9070200@intel.com>
Date: Fri, 01 Jun 2012 08:47:44 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Richard Weinberger <richard@....at>
CC: linux-mtd@...ts.infradead.org, tglx@...utronix.de,
dedekind1@...il.com, linux-kernel@...r.kernel.org,
Heinz.Egger@...utronix.de, tim.bird@...sony.com
Subject: Re: [PATCH] [RFC] UBI: Implement Fastmap support
On 23/05/12 14:06, Richard Weinberger wrote:
> Fastmap (aka checkpointing) allows attaching of an UBI volume in nearly
> constant time. Only a fixed number of PEBs has to be scanned.
>
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
> drivers/mtd/ubi/Makefile | 2 +-
> drivers/mtd/ubi/attach.c | 34 +-
> drivers/mtd/ubi/build.c | 25 +
> drivers/mtd/ubi/eba.c | 18 +-
> drivers/mtd/ubi/fastmap.c | 1240 +++++++++++++++++++++++++++++++++++++++++++
> drivers/mtd/ubi/ubi-media.h | 119 +++++
> drivers/mtd/ubi/ubi.h | 68 +++-
> drivers/mtd/ubi/wl.c | 184 +++++++-
> 8 files changed, 1667 insertions(+), 23 deletions(-)
> create mode 100644 drivers/mtd/ubi/fastmap.c
>
...
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> new file mode 100644
> index 0000000..7757e5a
> --- /dev/null
> +++ b/drivers/mtd/ubi/fastmap.c
...
> +/**
> + * ubi_update_fastmap - will be called by UBI if a volume changes or
> + * a fastmap pool becomes full.
> + * @ubi: UBI device object
> + */
> +int ubi_update_fastmap(struct ubi_device *ubi)
> +{
> + int ret, i;
> + struct ubi_fastmap_layout *new_fm;
> +
> + if (ubi->ro_mode)
> + return 0;
> +
> + new_fm = kzalloc(sizeof(*new_fm), GFP_KERNEL);
> + if (!new_fm)
> + return -ENOMEM;
> +
> + new_fm->size = sizeof(struct ubi_fm_hdr) + \
> + sizeof(struct ubi_fm_scan_pool) + \
> + (ubi->peb_count * sizeof(struct ubi_fm_ec)) + \
> + (sizeof(struct ubi_fm_eba) + \
> + (ubi->peb_count * sizeof(__be32))) + \
> + sizeof(struct ubi_fm_volhdr) * UBI_MAX_VOLUMES;
> + new_fm->size = roundup(new_fm->size, ubi->leb_size);
> +
> + new_fm->used_blocks = new_fm->size / ubi->leb_size;
> +
> + for (i = 0; i < new_fm->used_blocks; i++) {
> + new_fm->e[i] = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
> + if (!new_fm->e[i]) {
> + while (i--)
> + kfree(new_fm->e[i]);
> +
> + kfree(new_fm);
> + return -ENOMEM;
> + }
> + }
> +
> + ubi->old_fm = ubi->fm;
> + ubi->fm = NULL;
> +
> + spin_lock(&ubi->wl_lock);
> + new_fm->e[0]->pnum = ubi_wl_get_fm_peb(ubi, UBI_FM_MAX_START);
> + spin_unlock(&ubi->wl_lock);
> +
> + if (ubi->old_fm) {
> + /* no fresh early PEB was found, reuse the old one */
> + if (new_fm->e[0]->pnum < 0) {
> + struct ubi_ec_hdr *ec_hdr;
> +
> + ec_hdr = kzalloc(ubi->ec_hdr_alsize, GFP_KERNEL);
> + if (!ec_hdr) {
> + kfree(new_fm);
> +
> + return -ENOMEM;
> + }
> +
> + /* we have to erase the block by hand */
> +
> + ret = ubi_io_read_ec_hdr(ubi, ubi->old_fm->e[0]->pnum,
> + ec_hdr, 0);
> + if (ret) {
> + ubi_err("Unable to read EC header");
> + kfree(new_fm);
> + kfree(ec_hdr);
> +
> + return ret;
> + }
> +
> + ret = ubi_io_sync_erase(ubi, ubi->old_fm->e[0]->pnum,
> + 0);
> + if (ret < 0) {
> + ubi_err("Unable to erase old SB");
> + kfree(new_fm);
> + kfree(ec_hdr);
> +
> + return ret;
> + }
> +
> + ec_hdr->ec += ret;
> + if (ec_hdr->ec > UBI_MAX_ERASECOUNTER) {
> + ubi_err("Erase counter overflow!");
> + kfree(new_fm);
> + kfree(ec_hdr);
> +
> + return -EINVAL;
> + }
> +
> + ret = ubi_io_write_ec_hdr(ubi, ubi->old_fm->e[0]->pnum,
> + ec_hdr);
> + kfree(ec_hdr);
> + if (ret) {
> + ubi_err("Unable to write new EC header");
> + kfree(new_fm);
> +
> + return ret;
> + }
> +
> + new_fm->e[0]->pnum = ubi->old_fm->e[0]->pnum;
> + new_fm->e[0]->ec = ubi->old_fm->e[0]->ec;
> + } else {
> + /* we've got a new early PEB, return the old one */
> + ubi_wl_put_fm_peb(ubi, ubi->old_fm->e[0]->pnum, 0);
> + new_fm->e[0]->ec = get_ec(ubi, new_fm->e[0]->pnum);
> + }
> +
> + /* return all other fastmap block to the wl system */
> + for (i = 1; i < ubi->old_fm->used_blocks; i++)
> + ubi_wl_put_fm_peb(ubi, ubi->old_fm->e[i]->pnum, 0);
It looks like, if you lose power at this point, the old fastmap may have
been erased but the new fastmap has not been written. That would mean
you lose the fastmap. Is that correct? I guess you need to write the
new fastmap first and then erase the old one.
> + } else {
> + if (new_fm->e[0]->pnum < 0) {
> + ubi_err("Could not find an early PEB");
> + kfree(new_fm);
> +
> + return -ENOSPC;
> + }
> + new_fm->e[0]->ec = get_ec(ubi, new_fm->e[0]->pnum);
> + }
> +
> + if (new_fm->used_blocks > UBI_FM_MAX_BLOCKS) {
> + ubi_err("Fastmap too large");
> + kfree(new_fm);
> +
> + return -ENOSPC;
> + }
> +
> + /* give the wl subsystem a chance to produce some free blocks */
> + cond_resched();
> +
> + for (i = 1; i < new_fm->used_blocks; i++) {
> + spin_lock(&ubi->wl_lock);
> + new_fm->e[i]->pnum = ubi_wl_get_fm_peb(ubi, -1);
> + spin_unlock(&ubi->wl_lock);
> +
> + if (new_fm->e[i]->pnum < 0) {
> + ubi_err("Could not get any free erase block");
> +
> + while (i--) {
> + ubi_wl_put_fm_peb(ubi, new_fm->e[i]->pnum, 0);
> + kfree(new_fm->e[i]);
> + }
> +
> + kfree(new_fm);
> +
> + return -ENOSPC;
> + }
> +
> + new_fm->e[i]->ec = get_ec(ubi, new_fm->e[i]->pnum);
> + }
> +
> + if (ubi->old_fm) {
> + for (i = 0; i < ubi->old_fm->used_blocks; i++)
> + kfree(ubi->old_fm->e[i]);
> +
> + kfree(ubi->old_fm);
> + ubi->old_fm = NULL;
> + }
> +
> + return ubi_write_fastmap(ubi, new_fm);
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists