linux-kernel - Re: [GIT PULL] ACPI & Power Management Patches for Linux-3.5-merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201206040203.29928.rjw@sisk.pl>
Date:	Mon, 4 Jun 2012 02:03:29 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Len Brown <lenb@...nel.org>,
	"linux-acpi" <linux-acpi@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] ACPI & Power Management Patches for Linux-3.5-merge

On Sunday, June 03, 2012, Linus Torvalds wrote:
> On Fri, Jun 1, 2012 at 11:32 PM, Len Brown <lenb@...nel.org> wrote:
> >
> > ps. Sorry for sending this request at the tails of the merge window --
> > I'll try to be earlier next time.
> 
> Christ, not only is it after I really wanted to do -rc1 (held up by
> the tty locking problems), but it doesn't even compile.
> 
> Find the bug (the compiler certainly did):
> 
> static inline int acpi_pm_device_sleep_state(struct device *d, int *p, int m)
> {
>         if (p)
>                 *p = ACPI_STATE_D0;
>         return (m >= ACPI_STATE_D0 && <= ACPI_STATE_D3) ? m : ACPI_STATE_D0;
> }
> 
> and no, it wasn't a merge error. That's what it looks like in your tree.
> 
> The commit was done yesterday. It clearly had *zero* testing.
> 
> Looking more at the pull as a result of this, I notice that almost
> every commit in that tree is from yesterday, and thus cleary cannot
> have been in -next. I was going to just fix up the obvious one-liner
> fixup, but looking at the bigger picture I'm going to say "3.6
> material" for this whole thing.

Well, perhaps you could take my branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git pm-acpi

which was included into the Len's pull, for 3.5?

It was ready a few days ago, and has been present in linux-next even longer
and contains fixes for real bugs.  I didn't push it myself, because it
generally is ACPI material, but since you're not going to take the Len's
tree now, can you please consider taking that branch at least?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/