linux-kernel - Re: [RFC 2/6] remoteproc: Pass struct fw to load_segments and find_rsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK=WgbafpAC+DZ71Oon_PyiWGAryAxzZvttpeiFY+A_agYcMFw@mail.gmail.com>
Date:	Sun, 3 Jun 2012 15:54:39 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	sjur.brandeland@...ricsson.com
Cc:	Loic PALLARDY <loic.pallardy@...ricsson.com>,
	Ludovic BARRE <ludovic.barre@...ricsson.com>,
	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Sjur Brændeland <sjurbren@...il.com>
Subject: Re: [RFC 2/6] remoteproc: Pass struct fw to load_segments and find_rsc_table.

On Tue, May 22, 2012 at 4:26 PM,  <sjur.brandeland@...ricsson.com> wrote:
> From: Sjur Brændeland <sjur.brandeland@...ricsson.com>
>
> Use struct firmware as arguments to functions rproc_find_rcs_table()
> and rproc_load_segments().

I'll keep reading through the patches to get the big picture, but in
general, it's best just to provide the incentive behind every change
in the commit log.

> +rproc_find_rsc_table(struct rproc *rproc, const struct firmware *fw,
>                                                        int *tablesz)
>  {
...
> +       /*
> +        * The ELF entry point is the rproc's boot addr (though this is not
> +        * a configurable property of all remote processors: some will always
> +        * boot at a specific hardcoded address).
> +        */
> +       rproc->bootaddr = ehdr->e_entry;
> +
...
> @@ -1032,15 +1039,8 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
> -       /*
> -        * The ELF entry point is the rproc's boot addr (though this is not
> -        * a configurable property of all remote processors: some will always
> -        * boot at a specific hardcoded address).
> -        */
> -       rproc->bootaddr = ehdr->e_entry;

Is this change related?

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/