linux-kernel - Re: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK=Wgba1SGzpoHhGcytoO3+zOkJ+92oZfwENZaWdfEzp7BTLNg@mail.gmail.com>
Date:	Mon, 4 Jun 2012 13:06:50 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	Sjur BRENDELAND <sjur.brandeland@...ricsson.com>
Cc:	Loic PALLARDY <loic.pallardy@...ricsson.com>,
	Ludovic BARRE <ludovic.barre@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Sjur Brændeland <sjurbren@...il.com>
Subject: Re: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc_table.

On Mon, Jun 4, 2012 at 12:56 PM, Sjur BRENDELAND
<sjur.brandeland@...ricsson.com> wrote:
> The sanity_check() is working on the ELF structures. And all ELF
> processing needs to be moved to a separate file. So if you want
> to keep the call to sanity_check() here, I need to make the
> sanity_check() function a separate handler. That could make sense,
> but will also bloat the struct rproc_fw_ops with one more function
> pointer.

I think it's OK.

Adding another handler is cheap, and if by doing so the code becomes
even slightly easier to read or maintain, it's probably worth it.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/