linux-kernel - Re: Is this code right in zram?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FCCAE54.3010602@redhat.com>
Date:	Mon, 04 Jun 2012 14:47:16 +0200
From:	Jerome Marchand <jmarchan@...hat.com>
To:	Joe Perches <joe@...ches.com>
CC:	John Moser <john.r.moser@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: Is this code right in zram?

On 06/04/2012 02:33 PM, Joe Perches wrote:
> On Mon, 2012-06-04 at 14:08 +0200, Jerome Marchand wrote:
>> It probably doesn't matter much.
> 
> Likely true.
> 
>> Apparently kcalloc() never got  a lot
>> of success and kzalloc(sizeof(foo) * num_foos) type of allocation are
>> more popular.
> 
> Likely false, especially in new code.
> 
> If you did greps, perhaps you are including the
> 	k.alloc(sizeof(*foo), GFP)
> forms in your uses multiply counts.

No. Actually I greped it and look quickly at which proportion of those
kzalloc() looked like the above. I have to admit that my sample was
small and certainly not evenly distributed around the source tree.

Jerome

> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/