linux-kernel - Re: [PATCH] ohci-nxp: Use ohci_finish_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FCCCE04.3000904@antcom.de>
Date:	Mon, 04 Jun 2012 17:02:28 +0200
From:	Roland Stigge <stigge@...com.de>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	gregkh@...uxfoundation.org, grant.likely@...retlab.ca,
	rob.herring@...xeda.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kevin.wells@....com, srinivas.bakki@....com
Subject: Re: [PATCH] ohci-nxp: Use ohci_finish_controller_resume()

Hi!

On 06/04/2012 04:29 PM, Alan Stern wrote:
>> OHCI drivers are supposed to use ohci_finish_controller_resume(). This patch
>> adds respective suspend and resume code to ohci-nxp. The following compiler
>> warning is fixed this way:
>>
>> drivers/usb/host/ohci-hub.c:321: warning: 'ohci_finish_controller_resume'
>> defined but not used
> 
> This is not a correct description of the patch.  A correct description 
> would be something like:
> 
> 	Add suspend/resume support to the ohci-nxp driver.
> 
> The compiler warning needs a completely different fix; 
> ohci_finish_controller_resume should be given a __maybe_unused 
> annotation.

Thanks for the suggestion! I'll rather do the latter.

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/