linux-kernel - RE: [patch 1/2] x86: mce Cleanup timer mess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F192F7E3F@ORSMSX104.amr.corp.intel.com>
Date:	Mon, 4 Jun 2012 18:14:38 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Chen Gong <gong.chen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	LKML <linux-kernel@...r.kernel.org>, "bp@...64.org" <bp@...64.org>,
	"x86@...nel.org" <x86@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: RE: [patch 1/2] x86: mce Cleanup timer mess

> Here Thomas changed original mode from "*n = max(*n/2, HZ/100);"
> to "iv = max(iv, (unsigned long) HZ/100);", which means *iv* will not
> be decremented but only incremented in _else_ branch. If so, eventually
> the *iv will be equal to *check_interval*. I don't think it makes sense.

It looks like Thomas just forgot the "/ 2" there while cleaning up.
I didn't see it either, nor did Boris when he acked it. Thank goodness
for your extra eyes looking at this.

Please send patch to fix it (so you get credit).

-Tony