linux-kernel - Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FCD3679.60706@redhat.com>
Date:	Mon, 04 Jun 2012 18:28:09 -0400
From:	Don Dutile <ddutile@...hat.com>
To:	Joe Perches <joe@...ches.com>
CC:	dwmw2@...radead.org, iommu@...ts.linux-foundation.org,
	mingo@...e.hu, linux-kernel@...r.kernel.org, chrisw@...hat.com,
	suresh.b.siddha@...el.com
Subject: Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*()

On 06/04/2012 06:15 PM, Joe Perches wrote:
> On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote:
>> Replace printk(KERN_*  with pr_*() functions.
>
> Please add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any include and remove the embedded PREFIX
> from each printk
>
>> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
>
> []
>
>>   			break;
>>   		}
>>   		pdev = pci_get_slot(bus, PCI_DEVFN(path->dev, path->fn));
>>   		if (!pdev) {
>> -			printk(KERN_WARNING PREFIX
>> -			"Device scope device [%04x:%02x:%02x.%02x] not found\n",
>> +			pr_warn(PREFIX "Device scope device"
>> +				"[%04x:%02x:%02x.%02x] not found\n",
>>   				segment, bus->number, path->dev, path->fn);
>
> Please don't split any format string.  You removed
> a space between the scope device and an open bracket.
> It's OK for format strings to exceed 80 chars.
>
>
Joe,
Thanks for the feeback.  I'll incorporate the changes once
others have a chance to review & feedback as well.

- Don

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/