linux-kernel - Re: [PATCH 1/2] mtip32xx: Remove 'registers' and 'flags' from sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120605093314.GC21560@kroah.com>
Date:	Tue, 5 Jun 2012 18:33:14 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Asai Thambi S P <asamymuthupa@...ron.com>
Cc:	Jens Axboe <axboe@...nel.dk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sam Bradshaw <sbradshaw@...ron.com>
Subject: Re: [PATCH 1/2] mtip32xx: Remove 'registers' and 'flags' from sysfs

On Mon, Jun 04, 2012 at 12:43:03PM -0700, Asai Thambi S P wrote:
> 
> This patch removes entries 'registers' and 'flags' from sysfs. Updated ABI file
> to reflect this change.
> 
> Reported-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Asai Thambi S P <asamymuthupa@...ron.com>

Much nicer, thanks for doing this:

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

But, one question on a different sysfs file:

>  What:           /sys/block/rssd*/status
>  Date:           April 2012
>  KernelVersion:  3.4
>  Contact:        Asai Thambi S P <asamymuthupa@...ron.com>
>  Description:    This is a read-only file. Indicates the status of the device.

What "status" is this showing?  Why is this a sysfs file?  Who
needs/wants it?

Also, if you really want to properly create sysfs files, use the default
attributes for the driver.  As it is, you are creating them after
userspace is notified about the device showing up, which races with the
creation of your additional file(s).  Use the properly driver core field
to have the core create, and remove them, automatically, which saves you
code, and fixes bugs you didn't realize you had :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/