linux-kernel - Re: [PATCH] staging/wlan-ng: Fix the checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHdPZaNf2BL9pfYm-0-e9ij7UqpwmT_fYnex1fDr-Ce+3vjz=A@mail.gmail.com>
Date:	Tue, 5 Jun 2012 15:53:25 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/wlan-ng: Fix the checkpatch warnings

Hi Greg,

Thanks for the review.

On Tue, Jun 5, 2012 at 9:28 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Sun, May 20, 2012 at 07:01:42PM +0530, Devendra Naga wrote:
>> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
>> ---
>>  drivers/staging/wlan-ng/cfg80211.c |   27 +++++++++++++++++++--------
>>  1 file changed, 19 insertions(+), 8 deletions(-)
>
>
> Ok, you sent me 5 patches, all with the same subject (except for 3 of
> them you used x/3, which was nice, but you duplicated 3/3 for some
> reason.)
>
No i actually copy pasted your name wrongly, so i resent it again with
correct name.
> I can't accept that, please be more specific in your subject: line.
>
> Also, in the body, say exactly what checkpatch warnings you fixed, and,
> if you fixed more than one type of warning, that might indicate that you
> should break the patch up into different parts.
>
Ok. so similar changes constitute a patch, and if the change differs a
new patch should be there.
> So, I've dropped all 5 patches you've sent me, please redo and resend.
>
Thanks, i will redo again.
> thanks,
>
> greg k-h

Thanks,
Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/