linux-kernel - RE: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5723ED3022C1484092D8E8139108116905581F3ACF@MX18A.corp.emc.com>
Date:	Mon, 4 Jun 2012 21:48:57 -0400
From:	<Tao.Guo@....com>
To:	<shli@...nel.org>, <glorioustao@...il.com>
CC:	<linux-kernel@...r.kernel.org>, <neilb@...e.de>, <axboe@...nel.dk>,
	<stable@...r.kernel.org>, <akpm@...ux-foundation.org>
Subject: RE: [PATCH 1/2] block: Move general unplug callback function from
 md/raid to blk-core

If you ever tried to implement unplug function in umem, you would find the code was almost identical as in dm/raid driver.
For other components which also need such unplug mechanism, it will much more convenient to have such facilities.
PS: What's your specific concern about blk_plug_cb handles each request_queue?

Thanks,
-Tao

> -----Original Message-----
> From: Shaohua Li [mailto:shlikernel@...il.com] On Behalf Of Shaohua Li
> Sent: Tuesday, June 05, 2012 9:21 AM
> To: Tao Guo
> Cc: linux-kernel@...r.kernel.org; Guo, Tao; Neil Brown; Jens Axboe;
> stable@...r.kernel.org; Andrew Morton
> Subject: Re: [PATCH 1/2] block: Move general unplug callback function
> from md/raid to blk-core
> 
> On Mon, Jun 04, 2012 at 10:41:50AM -0400, Tao Guo wrote:
> > Other components may also require an unplug callback, so move this
> > function from md/raid to block generic layer.
> 
> I saw no point this should be generic code, for example, why
> blk_plug_cb only
> handles only one request_queue? If umem needs unplug, just do in it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/