linux-kernel - Re: [PATCH] powerpc/ftrace: Do not trace restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Jun 2012 22:33:17 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH] powerpc/ftrace: Do not trace restore_interrupts()

On Mon, 2012-06-04 at 22:27 -0400, Steven Rostedt wrote:
> As I was adding code that affects all archs, I started testing function
> tracer against PPC64 and found that it currently locks up with 3.4
> kernel. I figured it was due to tracing a function that shouldn't be, so
> I went through the following process to bisect to find the culprit:
> 
>  cat /debug/tracing/available_filter_functions > t
>  num=`wc -l t`
>  sed -ne "1,${num}p" t > t1
>  let num=num+1
>  sed -ne "${num},$p" t > t2
>  cat t1 > /debug/tracing/set_ftrace_filter
>  echo function /debug/tracing/current_tracer
>  <failed? bisect t1, if not bisect t2>
> 
> It finally came down to this function: restore_interrupts()
> 
> I'm not sure why this locks up the system. It just seems to prevent
> scheduling from occurring. Interrupts seem to still work, as I can ping
> the box. But all user processes freeze.
> 
> When restore_interrupts() is not traced, function tracing works fine.
> 
> Cc: stable@...nel.org

This is what I get for cut-and-pasting from a random git commit. That
should be:

Cc: stable@...r.kernel.org

-- Steve

> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> index 641da9e..64eec59 100644
> --- a/arch/powerpc/kernel/irq.c
> +++ b/arch/powerpc/kernel/irq.c
> @@ -277,7 +277,7 @@ EXPORT_SYMBOL(arch_local_irq_restore);
>   * NOTE: This is called with interrupts hard disabled but not marked
>   * as such in paca->irq_happened, so we need to resync this.
>   */
> -void restore_interrupts(void)
> +void notrace restore_interrupts(void)
>  {
>  	if (irqs_disabled()) {
>  		local_paca->irq_happened |= PACA_IRQ_HARD_DIS;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/