linux-kernel - [tip:smp/hotplug] S390: Smp: remove call to ipi_call_lock()/ ipi_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-46ce7fbfdbe0be6aaf0e816331aac08a74a00e5a@git.kernel.org>
Date:	Tue, 5 Jun 2012 08:46:10 -0700
From:	tip-bot for Yong Zhang <yong.zhang0@...il.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	peterz@...radead.org, schwidefsky@...ibm.com,
	srivatsa.bhat@...ux.vnet.ibm.com, heiko.carstens@...ibm.com,
	tglx@...utronix.de, yong.zhang0@...il.com
Subject: [tip:smp/hotplug] S390: Smp: remove call to ipi_call_lock()/
 ipi_call_unlock()

Commit-ID:  46ce7fbfdbe0be6aaf0e816331aac08a74a00e5a
Gitweb:     http://git.kernel.org/tip/46ce7fbfdbe0be6aaf0e816331aac08a74a00e5a
Author:     Yong Zhang <yong.zhang0@...il.com>
AuthorDate: Tue, 29 May 2012 15:15:59 +0800
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Tue, 5 Jun 2012 17:27:12 +0200

S390: Smp: remove call to ipi_call_lock()/ipi_call_unlock()

ipi_call_lock/unlock() lock resp. unlock call_function.lock. This lock
protects only the call_function data structure itself, but it's
completely unrelated to cpu_online_mask. The mask to which the IPIs
are sent is calculated before call_function.lock is taken in
smp_call_function_many(), so the locking around set_cpu_online() is
pointless and can be removed.

[ tglx: Massaged changelog ]

Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
Cc: ralf@...ux-mips.org
Cc: sshtylyov@...sta.com
Cc: david.daney@...ium.com
Cc: nikunj@...ux.vnet.ibm.com
Cc: paulmck@...ux.vnet.ibm.com
Cc: axboe@...nel.dk
Cc: peterz@...radead.org
Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
Cc: Heiko Carstens <heiko.carstens@...ibm.com>
Cc: linux390@...ibm.com
Cc: linux-s390@...r.kernel.org
Link: http://lkml.kernel.org/r/1338275765-3217-5-git-send-email-yong.zhang0@gmail.com
Acked-by: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
Acked-by: Peter Zijlstra <peterz@...radead.org>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/s390/kernel/smp.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
index 15cca26..8dca9c2 100644
--- a/arch/s390/kernel/smp.c
+++ b/arch/s390/kernel/smp.c
@@ -717,9 +717,7 @@ static void __cpuinit smp_start_secondary(void *cpuvoid)
 	init_cpu_vtimer();
 	pfault_init();
 	notify_cpu_starting(smp_processor_id());
-	ipi_call_lock();
 	set_cpu_online(smp_processor_id(), true);
-	ipi_call_unlock();
 	local_irq_enable();
 	/* cpu_idle will call schedule for us */
 	cpu_idle();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/