linux-kernel - Re: [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FCE4BD0.8030703@micron.com>
Date:	Tue, 5 Jun 2012 11:11:28 -0700
From:	Asai Thambi S P <asamymuthupa@...ron.com>
To:	Jens Axboe <axboe@...nel.dk>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Sam Bradshaw <sbradshaw@...ron.com>
Subject: Re: [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting

On 6/5/2012 11:03 AM, Asai Thambi S P wrote:

> On 6/5/2012 12:17 AM, Jens Axboe wrote:
> 
>> On 06/04/2012 09:44 PM, Asai Thambi S P wrote:
>>> @@ -4062,10 +4210,20 @@ static int __init mtip_init(void)
>>>  	}
>>>  	mtip_major = error;
>>>  
>>> +	if (!dfs_parent) {
>>> +		dfs_parent = debugfs_create_dir("rssd", NULL);
>>> +		if (IS_ERR_OR_NULL(dfs_parent)) {
>>> +			printk(KERN_WARNING "Error creating debugfs parent\n");
>>> +			dfs_parent = NULL;
>>> +		}
>>> +	}
>>> +
>>
>> Why would dfs_parent ever be non-NULL here?
>>
>> Apart from that, looks fine.
>>
> 
> I moved this part from mtip_hw_debugfs_init(), dfs_parent will not be NULL here.
> 


dfs_parent will be NULL here :)

--
Regards,
Asai Thambi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/