linux-kernel - Re: [PATCH] slimbus: Linux driver framework for SLIMbus.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120605205721.GA20560@plastictigers.com>
Date:	Tue, 5 Jun 2012 16:57:21 -0400
From:	Marc Butler <marc@...stictigers.com>
To:	Sagar Dharia <sdharia@...eaurora.org>
Cc:	davidb@...eaurora.org, bryanh@...eaurora.org,
	kheitke@...eaurora.org, gclemson@...ience.com,
	broonie@...nsource.wolfsonmicro.com, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, rob@...dley.net,
	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	ohad@...ery.com, gregkh@...uxfoundation.org,
	linus.walleij@...aro.org, rusty@...tcorp.com.au,
	joerg.roedel@....com, trenn@...e.de, ak@...ux.intel.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] slimbus: Linux driver framework for SLIMbus.

The patch below fixes an bug where devices that have not be matched
to a driver will result in a segv when the bus is shutdown.

I am not sure what the policy on patches-on-patches is, it just
doesn't seem workable. So I this will be the first and last. Instead I
am maintaing a git repository that tracks Linus's tree:

git://git.plastictigers.com/slimbus.git

or it can be browsed via the web:

http://git.plastictigers.com/

Currently there are 3 branches:

slimbus-rfc-patch   : the original rfc patch (for reference)
slimbus-patch       : the current patch (as posted by Sagar)
slimbus-patch-fixes : slimbus-patch + fixes (like the one below)

There will likely be a couple of new branches in the future.

If anyone has a suggestion on a better way of doing this I am all
ears.

---
 drivers/slimbus/slimbus.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/slimbus/slimbus.c b/drivers/slimbus/slimbus.c
index 6d20241..673222c 100644
--- a/drivers/slimbus/slimbus.c
+++ b/drivers/slimbus/slimbus.c
@@ -125,6 +125,9 @@ static void slim_device_shutdown(struct device *dev)
 	struct slim_device *slim_dev;
 	struct slim_driver *driver;
 
+	if (!dev->driver)
+		return;
+
 	if (dev->type == &slim_dev_type)
 		slim_dev = to_slim_device(dev);
 	else
-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/