lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 06 Jun 2012 00:55:00 +0200 From: Kay Sievers <kay@...y.org> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Joe Perches <joe@...ches.com>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-arm-kernel@...ts.infradead.org, linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org, alsa-devel@...a-project.org, Kay Sievers <kay.sievers@...y.org> Subject: Re: [PATCH 0/8] Rework KERN_<LEVEL> On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote: > devkmsg_writev() does weird and wonderful things with > facilities/levels. That function incorrectly returns "success" when > copy_from_user() faults, btw. Oh. Better? Thanks, Kay From: Kay Sievers <kay@...y.org> Subject: kmsg: /dev/kmsg - properly return possible copy_from_user() failure Reported-By: Andrew Morton <akpm@...ux-foundation.org> Signed-off-by: Kay Sievers <kay@...y.org --- printk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/printk.c b/kernel/printk.c index 32462d2..6bdacab 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -365,8 +365,10 @@ static ssize_t devkmsg_writev(struct kiocb *iocb, const struct iovec *iv, line = buf; for (i = 0; i < count; i++) { - if (copy_from_user(line, iv[i].iov_base, iv[i].iov_len)) + if (copy_from_user(line, iv[i].iov_base, iv[i].iov_len)) { + ret = -EFAULT; goto out; + } line += iv[i].iov_len; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists