linux-kernel - Re: [PATCH] staging: comedi: remove private header comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120605032314.GB32598@kroah.com>
Date:	Mon, 4 Jun 2012 20:23:14 -0700
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Ian Abbott <ian.abbott@....co.uk>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>
Subject: Re: [PATCH] staging: comedi: remove private header comedi_pci.h

On Tue, May 22, 2012 at 11:06:24AM +0100, Ian Abbott wrote:
> On 2012-05-22 01:12, H Hartley Sweeten wrote:
> >Remove the private header, comedi_pci.h, by moving the two
> >helper functions into divers.c and providing the prototypes
> >in comedidev.h.
> >
> >This allows the comedi_pci_enable/disable helper functions
> >to be shared instead of having an inline version in every
> >comedi pci driver.
> 
> I'm wondering if these functions should be EXPORT_SYMBOL() or
> EXPORT_SYMBOL_GPL() since they were originally inline functions.
> 
> Opinions?

Are there any known out-of-tree comedi drivers?  I say leave this as-is
and see if anyone complains :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/