linux-kernel - Re: [PATCH 2/2] staging: comedi: cb_pcidas64: Fixed an if-statement check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Jun 2012 20:43:18 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Dimitrios Semitsoglou-Tsiapos <dimitrios.semitsoglou@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: comedi: cb_pcidas64: Fixed an if-statement
 check

On Tue, May 29, 2012 at 12:51:45AM +0300, Dimitrios Semitsoglou-Tsiapos wrote:
> Fixed in if-statemnt responsible for a sanity check inside the
> prep_ao_dma function.
> 
> Signed-off-by: Dimitrios Semitsoglou-Tsiapos <dimitrios.semitsoglou@...il.com>
> ---
>  drivers/staging/comedi/drivers/cb_pcidas64.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index 6f7fd99..a2e6f96 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -3392,8 +3392,8 @@ static int prep_ao_dma(struct comedi_device *dev, const struct comedi_cmd *cmd)
>  	num_bytes = load_ao_dma_buffer(dev, cmd);
>  	if (num_bytes == 0)
>  		return -1;
> -	if (num_bytes >= DMA_BUFFER_SIZE) ;
> -	load_ao_dma(dev, cmd);
> +	if (num_bytes >= DMA_BUFFER_SIZE)
> +		load_ao_dma(dev, cmd);

Are you sure about this change?  I think someone forgot to include an
error check here, the driver was working with this function always being
called, and now you only do it for the extreme case.

Have you checked it somehow?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/