linux-kernel - Re: [PATCH v2] remove no longer use of pdflush interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 17:32:14 +0800
From:	Wanpeng Li <liwp.linux@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Boaz Harrosh <bharrosh@...asas.com>,
	Wanpeng Li <liwp.linux@...il.com>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Rob Landley <rob@...dley.net>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	"David S. Miller" <davem@...emloft.net>, Jan Kara <jack@...e.cz>,
	Mel Gorman <mgorman@...e.de>,
	Minchan Kim <minchan.kim@...il.com>,
	David Howells <dhowells@...hat.com>,
	James Morris <james.l.morris@...cle.com>,
	Ingo Molnar <mingo@...e.hu>,
	Michel Lespinasse <walken@...gle.com>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Gavin Shan <shangw@...ux.vnet.ibm.com>,
	Wanpeng Li <liwp@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2] remove no longer use of pdflush interface

On Wed, Jun 06, 2012 at 10:37:34AM +0300, Boaz Harrosh wrote:
>On 06/06/2012 10:31 AM, Boaz Harrosh wrote:
>
>> On 06/06/2012 01:28 AM, Andrew Morton wrote:
>> 
>>> On Tue,  5 Jun 2012 17:26:11 +0800
>>> Wanpeng Li <liwp.linux@...il.com> wrote:
>>>
>>> So perhaps the solution is to give up on the generic proc_obsolete()
>>> idea, and just add a handler specifically for nr_pdflush_threads, whcih
>>> uses printk_once().
>>>
>> 
>> 
>> If there are many users than a self made print once is worth it
>> we can use the ctl_table->data pointer for this, some thing like:
>> 
>> int nr_pdflush_was_printed;
>> 
>> @@ -1095,11 +1095,9 @@ static struct ctl_table vm_table[] = {
>>  		.extra1		= &zero,
>>  	},
>>  	{
>> -		.procname	= "nr_pdflush_threads",
>> -		.data		= &nr_pdflush_threads,
>> -		.maxlen		= sizeof nr_pdflush_threads,
>> -		.mode		= 0444 /* read-only*/,
>> -		.proc_handler	= proc_dointvec,
>> +		.data		= &nr_pdflush_was_printed,
>> +		.procname       = "nr_pdflush_threads",
>> +		.mode           = 0444 /* read-only */,
>> +		.proc_handler   = proc_obsolete,
>>  	},
>> 
>> 
>> +/* notice associated proc deprecated */
>> +int proc_deprecated(struct ctl_table *table, int write,
>> +		    void __user *buffer, size_t *lenp, loff_t *ppos, )
>> +{
>> +	if (*ctl_table->data) {
>
>
>+	if(!*ctl_table->data) {
    if(!*table->data) {
>
>> +		printk(KERN_WARNING "%s exported in /proc is deprecated\n",
>> +			table->procname);
>> +		*ctl_table->data = 0;
>
>
>+		*ctl_table->data = 1;
        *table->data = 1;

Regards,
Wanpeng Li

>
>stupid me, time for coffee
>
>Boaz
>
>> +	}
>> +	return -ENOSYS;
>> +}
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/