linux-kernel - Re: [PATCH] regulator: palmas: Slightly code change for better readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 10:51:19 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Graeme Gregory <gg@...mlogic.co.uk>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: palmas: Slightly code change for better
	readability

On Wed, Jun 06, 2012 at 03:50:50PM +0800, Axel Lin wrote:

> if (id == PALMAS_REG_SMPS10) {
>         do something for the case id == PALMAS_REG_SMPS10;
> } else {
>         do something for the cases id != PALMAS_REG_SMPS10;
> }

If we're going to do this a switch statement would be even better...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/