linux-kernel - Re: [PATCH 1/2] Allow constructor name selection by architecture.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 11:12:53 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Vincent Sanders <vincent.sanders@...labora.co.uk>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Vincent Sanders <vince@...labora.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] Allow constructor name selection by architecture.

On Tue, May 29, 2012 at 10:06:14AM +0100, Russell King - ARM Linux wrote:
> On Mon, May 28, 2012 at 10:30:05PM +0200, Sam Ravnborg wrote:
> > On Mon, May 28, 2012 at 07:33:37PM +0100, Vincent Sanders wrote:
> > > From: Vincent Sanders <vince@...labora.co.uk>
> > > 
> > > The constructor symbol name is different between platforms. Allow this
> > > to be selected by configuration and set suitable default values.
> > > 
> > > Signed-off-by: Vincent Sanders <vincent.sanders@...labora.co.uk>
> > > ---
> > >  include/asm-generic/vmlinux.lds.h |    6 +++---
> > >  init/Kconfig                      |    6 ++++++
> > >  kernel/module.c                   |    2 +-
> > >  3 files changed, 10 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> > > index 8aeadf6..fd34808 100644
> > > --- a/include/asm-generic/vmlinux.lds.h
> > > +++ b/include/asm-generic/vmlinux.lds.h
> > > @@ -471,9 +471,9 @@
> > >  	}
> > >  
> > >  #ifdef CONFIG_CONSTRUCTORS
> > > -#define KERNEL_CTORS()	. = ALIGN(8);			   \
> > > -			VMLINUX_SYMBOL(__ctors_start) = .; \
> > > -			*(.ctors)			   \
> > > +#define KERNEL_CTORS()	. = ALIGN(8);					\
> > > +			VMLINUX_SYMBOL(__ctors_start) = .;		\
> > > +			*(CONFIG_CONSTRUCTORS_NAME)			\
> > >  			VMLINUX_SYMBOL(__ctors_end) = .;
> > 
> > What is wrong with adding both "standard" names for ctors uncnditionally?
> > Like this:
> > > 			*(.ctors)			   \
> > > +			*(.init_array)			   \
> 
> That doesn't get rid of CONFIG_CONSTRUCTORS_NAME, because it's needed
> in the module code.  Do you have a suggestion to solve that as well?

Ping.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/