lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Jun 2012 13:43:50 +0200 From: Stephane Eranian <eranian@...gle.com> To: Peter Zijlstra <peterz@...radead.org> Cc: linux-kernel@...r.kernel.org, zheng.z.yan@...ux.intel.com Subject: Re: [PATCH] perf, x86: Fix Intel shared extra MSR allocation On Wed, Jun 6, 2012 at 12:53 PM, Peter Zijlstra <peterz@...radead.org> wrote: > On Wed, 2012-06-06 at 12:36 +0200, Peter Zijlstra wrote: >> On Wed, 2012-06-06 at 12:35 +0200, Stephane Eranian wrote: >> > Ok, I found the problem. It was in intel_fixup_er(). >> > Unlike in the original code, this routine must update >> > the event->extra_reg.idx to the idx parameter instead >> > of trying to swap out from it. >> >> Ah indeed. Thanks! > > > static void intel_fixup_er(struct perf_event *event, int idx) > { > event->hw.extra_reg.idx = idx; > > if (idx == EXTRA_REG_RSP_0) { > event->hw.config &= ~INTEL_ARCH_EVENT_MASK; > event->hw.config |= 0x01b7; > event->hw.extra_reg.reg = MSR_OFFCORE_RSP_0; > } else if (idx == EXTRA_REG_RSP_1) { > event->hw.config &= ~INTEL_ARCH_EVENT_MASK; > event->hw.config |= 0x01bb; > event->hw.extra_reg.reg = MSR_OFFCORE_RSP_1; > } > } > > Like that then? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists