| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Jun 2012 14:50:09 +0100 From: Matthew Garrett <mjg@...hat.com> To: Khalid Aziz <khalid.aziz@...com> Cc: linux-kernel@...r.kernel.org, bhelgaas@...gle.com, linux-pci@...r.kernel.org Subject: Re: [PATCH] Disable Bus Master on PCI device shutdown On Fri, Apr 27, 2012 at 01:00:33PM -0600, Khalid Aziz wrote: > Disable Bus Master bit on the device in > pci_device_shutdown() to ensure PCI devices do not continue > to DMA data after shutdown. This can cause memory > corruption in case of a kexec where the current kernel > shuts down and transfers control to a new kernel while a > PCI device continues to DMA to memory that does not belong > to it any more in the new kernel. This protects against the case where a piece of hardware is continuing to DMA even after the driver shutdown method has been called? I'm not convinced this is safe. Some Broadcom parts will crash if busmastering is disabled while they're still performing DMA, and they'll then hang the bus if reenabled. There's also the risk that the hardware will start DMAing again if it's reenabled after being shut down. It seems like you're covering over the case where the driver didn't correctly quiesce the hardware, but you risk triggering other bugs instead. -- Matthew Garrett | mjg59@...f.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists