[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2012 07:14:19 -0700
From: Andi Kleen <ak@...ux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
eranian@...gle.com
Subject: Re: [PATCH 3/5] perf, x86: Check LBR format capability
On Wed, Jun 06, 2012 at 12:40:24PM +0200, Peter Zijlstra wrote:
> On Tue, 2012-06-05 at 17:56 -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@...ux.intel.com>
> >
> > Double check the CPU has a LBR format we support before using it.
> >
> > Also I made the init functions __init while I was on it.
>
> Why? Its all after a model test anyway.
Because the spec says we should check it.
It could catch bad VMs and other inconsistencies and it's the right thing
to do.
-Andi
--
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists