[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2012 17:22:38 +0200
From: Borislav Petkov <bp@...en8.de>
To: ShuoX Liu <shuox.liu@...el.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Yanmin Zhang <yanmin_zhang@...ux.intel.com>,
"Luck, Tony" <tony.luck@...el.com>,
Andrew Morton <akpm@...ux-foundation.org>,
"andi@...stfloor.org" <andi@...stfloor.org>,
Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH v6 2/2] x86 mce: use new printk recursion disabling
interface
On Wed, Jun 06, 2012 at 04:34:21PM +0800, ShuoX Liu wrote:
> From: ShuoX Liu <shuox.liu@...el.com>
>
> On x86 machines, some times MCE happens just when kernel calls printk
> to output some log info to serial console, while usually MCE module in
> kernel is used to print out some hardware error information, such like
> bad cache or bad memory bank. That causes printk recursion and printk
> would omit MCE printk output.
>
> We hit it when running MTBF testing on Android ATOM mobiles.
>
> Here in mce_panic, we choose to disable printk recursion to make sure
> MCE logs printed out.
Just a minor nitpick: this should say "print_mce" or you can simply
remove the whole sentence - commit message is fine without it too.
Aside of that, those look ok to me.
Thanks.
--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists